Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most software stacks that run client bots (SC-Docker, Tournament Manager, SCHNAIL, for example) don't bother checking whether the client is connected before starting a game. There's not even an obviously good way to do this.
Instead they just launch the client bot, wait a few seconds, then launch StarCraft and pray the client is ready. This usually works, but when it doesn't, the bot fails to connect. The game is ruined.
This pull request aims to prevent failed connections by reducing the time required for client bots to be ready for connection, by allowing bots to include pre-extracted JNA binaries. You can include them side-by-side with your bot JAR to save time on extracting them before connecting.
These changes were vibecoded but have undergone several rounds of iteration and testing. In fresh-JVM startup tests on Windows with Java 8 x86 and JNA 5.18.1, pre-extracted DLLs reduced median time-to-connection-ready by about 45%.